Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building on Node 18 needs some tweaks #35

Open
koesper opened this issue Jan 30, 2023 · 1 comment
Open

Building on Node 18 needs some tweaks #35

koesper opened this issue Jan 30, 2023 · 1 comment

Comments

@koesper
Copy link

koesper commented Jan 30, 2023

I noticed that when you try to run the package as-is, on a recent version of node, there a few NODE_OPTIONS flags need to be set.
By changing these lines in package.json, i was able to build it:

"test-ci": "NODE_OPTIONS=--openssl-legacy-provider ng test ngx-tableau --code-coverage --no-watch --browsers HeadlessChrome",
and
"build-tableau": "NODE_OPTIONS=--no-experimental-fetch ng build --prod ngx-tableau",

By setting these options, you revert some deprecations between node v16 and v18, although updating a bunch of dependencies is probably the best way forward.

@hmartos
Copy link
Collaborator

hmartos commented Jan 31, 2023

Hi @koesper,

I'm aware that the dependencies need to be updated, and the dependabot will agree with me...

I'm afraid I don't have a lot of time to maintain these Open Source projects but feel free to make a Pull Request with the updated dependencies, and I will review them and create a new major release.

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants