Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async error with readme example #61

Open
timint opened this issue Nov 20, 2024 · 2 comments
Open

Async error with readme example #61

timint opened this issue Nov 20, 2024 · 2 comments

Comments

@timint
Copy link

timint commented Nov 20, 2024

Readme example is producing an error:

import { svgicons2svgfont } from 'gulp-svgicons2svgfont';

gulp.task('Iconfont', () => {
  svgicons2svgfont(['assets/icons/*.svg'], {
    fontName: 'myfont',
  })
    .on('glyphs', function (glyphs) {
      console.log(glyphs);
      // Here generate CSS/SCSS  for your glyphs ...
    })
    .pipe(gulp.dest('www/font/'));
});

The following tasks did not complete: build, fonticons
Did you forget to signal async completion?

So I tried adding async:

gulp.task('Iconfont', async () => {

Finished 'Iconfont' after 12 ms

All good.

@nfroidure
Copy link
Owner

Thank for the report, feel free to PR a change.

@timint
Copy link
Author

timint commented Nov 20, 2024

Sure, I can do that. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants