Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateTimePicker]: Current or Selected Day Highlighted in Other Months #380

Open
bah99 opened this issue Dec 9, 2024 · 2 comments
Open
Labels
area: datetimepicker Issues about datetimepicker enhancement This issue is tracking a function should be enhanced

Comments

@bah99
Copy link

bah99 commented Dec 9, 2024

Hello,

I'm not sure if this is a feature or an unintended behavior, but the current day or the selected day is being highlighted for all months, regardless of whether the date is relevant. This behavior is confusing and inconsistent with how Angular Material date pickers function.

Examples

  • Current Day (Not Selected):
    In the following screenshots, the current day's date is highlighted in every month, even when navigating to months where it doesn't make sense.

    Current Day Highlight 1
    Current Day Highlight 2

  • Selected Day:
    Similarly, when a specific day is selected, it appears highlighted across all months, creating further confusion:

    Selected Day Highlight 1
    Selected Day Highlight 2

Question

Is this an expected feature, or does it require a fix? If it's intentional, is there a way to disable this behavior? It seems inconsistent with the standard Angular Material date picker implementation.

Thank you in advance for your help!

@bah99 bah99 changed the title Issue: Current or Selected Day Highlighted in Other Months [DateTimePicker]: Current or Selected Day Highlighted in Other Months Dec 9, 2024
@bah99
Copy link
Author

bah99 commented Dec 12, 2024

A new PR addressing this issue has been created: #381

@nzbin nzbin added enhancement This issue is tracking a function should be enhanced area: datetimepicker Issues about datetimepicker labels Dec 12, 2024
@nzbin
Copy link
Member

nzbin commented Dec 12, 2024

Thanks for your PR, the active cell logic is correct but it should be enhanced. The gray cell should only be highlighted when keyboard focused. Please check the Material does.

image

The datetimepicker's a11y is not very well now. It should add a keyboard focus monitor and improve the styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: datetimepicker Issues about datetimepicker enhancement This issue is tracking a function should be enhanced
Projects
None yet
Development

No branches or pull requests

2 participants