Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Pack Security support #78

Closed
corneversloot opened this issue Jul 6, 2018 · 4 comments
Closed

X-Pack Security support #78

corneversloot opened this issue Jul 6, 2018 · 4 comments

Comments

@corneversloot
Copy link

Hi there, I am considering using this Elasticsearch connector for a project as it looks like a good fit what what I need. The Elasticsearch will be secured though using X-Pack so I am wondering weather this connector sopports that. A (very) quick review of the code gives me the impression it is not supported. Is this correct, and if so do you have any plans to add it any time soon? Thanks!

@sjudeng
Copy link
Contributor

sjudeng commented Jul 6, 2018

Hello. SSL is supported but not basic authentication. It should be straightforward to add support for basic auth by adding username and password store parameters to ElasticDataStoreFactory and using those to add a default Authorization header when building the RestClient here. I'll try to make these updates in the coming weeks or else you're welcome to submit a PR if you'd like.

@corneversloot
Copy link
Author

It would be great if you can add it. If not, I might try to make changes later and submit a PR. Regardless of the particular project I might need it for I can see benefit of supporting X-Pack authorization to the connector. Thanks for the quick response!

@BinyaminSchein
Copy link

Why is this issue closed? How can you pass basic authentication parameters?

@sjudeng
Copy link
Contributor

sjudeng commented Mar 1, 2019

The new release candidate 2.14.2-RC1 includes updates to support basic authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants