Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentContainerID not fetched #284

Closed
kaiokenx10 opened this issue Apr 18, 2018 · 2 comments
Closed

CurrentContainerID not fetched #284

kaiokenx10 opened this issue Apr 18, 2018 · 2 comments

Comments

@kaiokenx10
Copy link

Hi,

I noticed that on the latest multicontainer docker env on AWS with ecs agent in version 1.17.2 the container id is empty and this ends up in empty upstream blocks for my nginx config in nginx-proxy container which uses docker-gen. Starting from ecs agent 1.16 the letsencrypt comapanion was not able to get its own container id, so it started supporting the ECS_CONTAINER_METADATA_FILE variable which holds the containerID in very simply way (it is a JSON file). My question is why similar approach can not be used here instead of attempts of doing the regexp matching on the /proc/self/cgroup? We could simply check if ECS_CONTAINER_METADATA_FILE is defined and use it for fetching "ContainerID".

@jwilder
Copy link
Collaborator

jwilder commented May 7, 2018

Sure. We could do that.

@buchdag
Copy link
Member

buchdag commented Aug 3, 2021

This should have been fixed by #336 and #345

@buchdag buchdag closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants