Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links to /internal in /shared-examples #4293

Closed
vepatel opened this issue Aug 25, 2023 · 1 comment · Fixed by #4435
Closed

Broken links to /internal in /shared-examples #4293

vepatel opened this issue Aug 25, 2023 · 1 comment · Fixed by #4435
Assignees
Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Milestone

Comments

@vepatel
Copy link
Contributor

vepatel commented Aug 25, 2023

Describe the bug
links to template path /internal/config are broken when referenced from https://github.com/nginxinc/kubernetes-ingress/tree/v3.2.1/examples/shared-examples/custom-templates

To Reproduce
Steps to reproduce the behavior:
Click on the links in Notes section:

Expected behavior
A clear and concise description of what you expected to happen.
Change the paths to ref:

@vepatel vepatel added bug An issue reporting a potential bug backlog Pull requests/issues that are backlog items labels Aug 25, 2023
@github-actions
Copy link

Hi @vepatel thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@vepatel vepatel changed the title Broken links in to /internal in /shared-examples Broken links to /internal in /shared-examples Aug 25, 2023
@vepatel vepatel added the documentation Pull requests/issues for documentation label Aug 25, 2023
@jjngx jjngx self-assigned this Sep 26, 2023
@jjngx jjngx added this to the v3.4.0 milestone Sep 26, 2023
@jjngx jjngx linked a pull request Sep 27, 2023 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items bug An issue reporting a potential bug documentation Pull requests/issues for documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants