Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - Add ip as an option to listeners #5994

Closed
1 task
Tracked by #5363
shaun-nx opened this issue Jul 10, 2024 · 2 comments
Closed
1 task
Tracked by #5363

POC - Add ip as an option to listeners #5994

shaun-nx opened this issue Jul 10, 2024 · 2 comments
Assignees
Labels
backlog Pull requests/issues that are backlog items
Milestone

Comments

@shaun-nx
Copy link
Contributor

shaun-nx commented Jul 10, 2024

As an engineer, I would like to have the option to set a specific IP for a listener so that I can create traffic rules for resources with static IP addresses.

UACs

Copy link

Hi @shaun-nx thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@shaun-nx shaun-nx added this to the v3.7.0 milestone Jul 10, 2024
@shaun-nx shaun-nx added backlog Pull requests/issues that are backlog items ready for refinement An issue that was triaged and it is ready to be refined labels Jul 10, 2024
@danielnginx danielnginx added ready for refinement An issue that was triaged and it is ready to be refined and removed ready for refinement An issue that was triaged and it is ready to be refined labels Jul 10, 2024
@shaun-nx shaun-nx removed the ready for refinement An issue that was triaged and it is ready to be refined label Jul 11, 2024
@AlexFenlon
Copy link
Contributor

Closing in favour of implementation of ip listener: #6067

Here is a describe of the GlobalConfiguration when ip listener is enabled.

kubectl describe gc my-release-nginx-ingress-controller
Name:         my-release-nginx-ingress-controller
Namespace:    default
Labels:       app.kubernetes.io/instance=my-release
              app.kubernetes.io/managed-by=Helm
              app.kubernetes.io/name=nginx-ingress
              app.kubernetes.io/version=3.7.0
              helm.sh/chart=nginx-ingress-1.4.0
Annotations:  meta.helm.sh/release-name: my-release
              meta.helm.sh/release-namespace: default
API Version:  k8s.nginx.org/v1
Kind:         GlobalConfiguration
Metadata:
  Creation Timestamp:  2024-07-25T13:33:40Z
  Generation:          3
  Resource Version:    20914
  UID:                 9bd8c5a7-fbb2-4272-b8e9-589f22ad78e7
Spec:
  Listeners:
    Ip:        127.0.0.1
    Name:      http-8084
    Port:      8084
    Protocol:  HTTP
Events:
  Type    Reason   Age               From                      Message
  ----    ------   ----              ----                      -------
  Normal  Updated  58m               nginx-ingress-controller  GlobalConfiguration default/my-release-nginx-ingress was updated
  Normal  Updated  1s (x3 over 58m)  nginx-ingress-controller  GlobalConfiguration default/my-release-nginx-ingress-controller was added or updated

This is the output snippet of the nginx.conf without the ip listener in GlobalConfiguration

...
server {
    listen 8084;
    listen [::]:8084;


    server_name cafe.example.com;

    set $resource_type "virtualserver";
    set $resource_name "cafe";
    set $resource_namespace "default";
...

This is the output snippet of the nginx.conf with the ip listener in GlobalConfiguration

...
server {
    listen 127.0.0.1:8084;
    listen [::]:8084;


    server_name cafe.example.com;

    set $resource_type "virtualserver";
    set $resource_name "cafe";
    set $resource_namespace "default";
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items
Projects
Archived in project
Development

No branches or pull requests

4 participants