Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Allow users to provide arbitrary pod annotations to allow users to mesh NGF with meshes like LinkerD #1771

Closed
mpstefan opened this issue Mar 25, 2024 Discussed in #1743 · 2 comments
Labels
helm-chart Relates to helm chart
Milestone

Comments

@mpstefan
Copy link
Collaborator

Discussed in #1743

Originally posted by estenrye March 20, 2024
I noticed while trying to mesh NGF into LinkerD's service mesh that the helm chart does not provide any means for me to inject the annotations required to mesh the NGF pods.

I propose adding an optional nginxGateway.podAnnotations value that would allow the user to provide these annotations.

It could look something like this:
https://github.com/estenrye/nginx-gateway-fabric/pull/1/files

@mpstefan mpstefan added the helm-chart Relates to helm chart label Mar 25, 2024
@mpstefan mpstefan added this to the v1.3.0 milestone Mar 25, 2024
@mpstefan
Copy link
Collaborator Author

Hey @estenrye, we 100% agree with this and we see you already created a PR to fix this in a fork.

Any chance you can create a PR for the project that we can merge in?

@mpstefan mpstefan modified the milestones: v1.3.0, v1.4.0 May 20, 2024
@sjberman
Copy link
Contributor

This has been fixed as part of #2250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-chart Relates to helm chart
Projects
Status: Done
Development

No branches or pull requests

2 participants