Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report error for policy when ancestor status slice is full #1987

Open
kate-osborn opened this issue May 17, 2024 · 1 comment
Open

Report error for policy when ancestor status slice is full #1987

kate-osborn opened this issue May 17, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@kate-osborn
Copy link
Contributor

Status on policies contains a slice of Ancestors, which has a max size of 16. If the slice is full, we consider the policy unimplementable but we do not signal this to the user in any way. We effectively ignore the policy.

The spec says

If this slice is full, implementations MUST NOT add further entries.
Instead they MUST consider the policy unimplementable and signal that
on any related resources such as the ancestor that would be referenced
here. For example, if this list was full on BackendTLSPolicy, no
additional Gateways would be able to reference the Service targeted by
the BackendTLSPolicy.

We need to figure out a way to signal this on the ancestor resource. One way to do this would be to add a condition to the ancestor. But this may overflow the ancestor's conditions.

@kate-osborn
Copy link
Contributor Author

See this thread for more info: #1940 (comment)

@mpstefan mpstefan added this to the v1.4.0 milestone May 20, 2024
@mpstefan mpstefan added the bug Something isn't working label May 20, 2024
@mpstefan mpstefan modified the milestones: v1.4.0, v2.1.0 Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants