Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseUrl input not present #37

Closed
alexw10 opened this issue Jun 5, 2019 · 1 comment
Closed

baseUrl input not present #37

alexw10 opened this issue Jun 5, 2019 · 1 comment

Comments

@alexw10
Copy link

alexw10 commented Jun 5, 2019

This is related to #36 and or a continuation of it since it got closed.
I still do not see this working even with doing the what your link in #36 says
Things I tried:
Removing completely which then angular 8 (not sure about previous versions) gives this
Error: No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.

I provide the APP_BASE_HREF in the module which gets the error gone but the svgs still are not being renderd.

I think the proper solution is an @input() for the base url property which is what this added.
danilowoz/react-content-loader#93

Without baseUrl it seems cannot have the <base href="/"> which Angular 8 seems to complain about it not being there.
Unless I am missing something?

Thoughts?

@NetanelBasal
Copy link
Member

Yes, we need to mimic the React version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants