forcing all non-multi geometries to be multi #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah hold off need to fix the multi case. |
|
@chelm looks good to me, merging unless you still want me to hold off. |
|
@ngoldman rock n roll |
ungoldman
added a commit
that referenced
this pull request
Mar 20, 2015
forcing all non-multi geometries to be multi
| { | ||
| "type": "Feature", | ||
| "geometry": { | ||
| "type": "Polygon", |
There was a problem hiding this comment.
@chelm sorry just caught this, should this be a MultiPolygon type?
There was a problem hiding this comment.
...and that breaks the tests, shoot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just wraps non-multis into multi. I actually need to create multi-geom test case though, so give me a little bit and this PR should have a new test with multis just to make sure its all safe and sound.