-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker itzmx fake peers report #161
Comments
you are right. downgraded to the bottom of the list. |
@kiwixz I'm not sure how you conclude that the peer number report is faked? If you are referring to that the two itzmx trackers report the same number of peers, it is because all four itzmx trackers are synced which I have confirmed with itzmx maintainer. If you are referring to that you cannot connect to those 12 peers reported by itzmx tracker, it is highly likely that those peers have poor connection between them and you. @ngosang Please further investigate this issue if possible. Thanks! |
All of this leads me believe the peers count is fake, whether or not intentional. |
@kiwixz Is this reproducible? I tested with a few dummy torrent and had not been able to reproduce this. In my test cases the itzmx tracker always report peer number to be 2, which is myself. Here is a screenshot: https://img.vim-cn.com/e2/178a47d6c6940a7f0058e466fae2f6523b1702.png I've contacted itzmx site owner and maintainer and talked about this issue. Their respond was that itzmx tracker did have some special tuning regarding heavily NATed environment in some region, but should not create false peer report in any way. Thanks for responding! If it is a reproducible issue I'll present it to itzmx maintainer. |
It looks like the problem is specific to tracker 1 and 3 (4 seems fine, 2 is down). Restarting the client will add one more peer to the list the tracker returns. Just forcing reannounce seems fine. A GET request on this link can actually add one duplicate peer, but not always. At time of writing, it returns:
Which decodes to: {
"complete": 6,
"downloaded": 0,
"incomplete": 13,
"interval": 1833,
"min interval": 916,
"peers": "<hex>6C A2 E5 C2 00 00 6C A2 E5 E6 00 00 8D 65 58 80 00 00 AC 44 E6 08 00 00 AC 44 E6 0E 00 00 AC 44 E6 14 00 00 AC 44 E6 1A 00 00 AC 44 E6 20 00 00 AC 44 E6 38 00 00 AC 44 E6 3E 00 00 AC 44 E6 56 00 00 AC 44 E6 62 00 00 AC 44 E6 68 00 00 B0 1F 68 D4 EA 60 AC 45 36 CD EA 60 AC 44 E6 6E EA 60 AC 44 E6 68 EA 60 AC 44 E6 50 EA 60 AC 44 E6 08 1A E1</hex>"
} So peers are:
So I guess there is a nasty bug somewhere. Good luck ! |
Thank you very much for taking time to produce a detailed test result! It does look very helpful. I'll talk to itzmx site maintainer about this and hopefully resolve the issue. Thanks again! |
@kiwixz @ngosang Please read the below response from the itzmx maintainer and consider moving the itzmx trackers back. According to the explaination from maintainer those extra peers that may appear in some test cases would not have any negative effect. Thanks!
|
@N46AN I changed the penalty for itzmx. Instead of moving to the bottom, I'm removing 10 seeds and 10 leechers before calculating the scoring. |
I'm not using Cloudflare, but I am using Nginx as proxy for the HTTP/HTTPS. All configuration (nginx, systemd, diff, etc.) can be found from: https://lelux.fi/tracker/conf/ The differences I made to the opentracker repository: $ curl https://lelux.fi/tracker/conf/proxy.diff
diff --git a/Makefile b/Makefile
index da2c8f1..7d4148e 100644
--- a/Makefile
+++ b/Makefile
@@ -30,7 +30,7 @@ BINDIR?=$(PREFIX)/bin
#FEATURES+=-DWANT_COMPRESSION_GZIP_ALWAYS
#FEATURES+=-DWANT_LOG_NETWORKS
#FEATURES+=-DWANT_RESTRICT_STATS
-#FEATURES+=-DWANT_IP_FROM_PROXY
+FEATURES+=-DWANT_IP_FROM_PROXY
#FEATURES+=-DWANT_FULLLOG_NETWORKS
#FEATURES+=-DWANT_LOG_NUMWANT
#FEATURES+=-DWANT_MODEST_FULLSCRAPES (Just enabling However, @nwps is running his tracker with Cloudflare. (of his trackers, |
These two trackers from the "best" list seems to fake the number of peers and seeds.
I noticed it on a low-traffic torrent I just uploaded.
The text was updated successfully, but these errors were encountered: