Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Light mode & Dark Mode #1201

Closed
4 of 5 tasks
Surajit0573 opened this issue Jan 25, 2024 · 6 comments
Closed
4 of 5 tasks

Feature: Add Light mode & Dark Mode #1201

Surajit0573 opened this issue Jan 25, 2024 · 6 comments
Assignees
Labels
💡 feature This generally contains addition/changes to features. invite me to the organisation Sends an invitation to your community organisation. JWOC medium status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@Surajit0573
Copy link

Description

I want to add a toggle button to toggle between light and dark mode.

Proposed Solution

I will create this feature using HTML, CSS, JavaScript, and add the button to navbar.

Screenshots

No response

🥦 Browser

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no)
@Surajit0573 Surajit0573 added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 💡 feature This generally contains addition/changes to features. labels Jan 25, 2024
@github-project-automation github-project-automation bot moved this to Todo in Milan Jan 25, 2024
Copy link

Hello @Surajit0573, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@tamalCodes
Copy link
Member

tamalCodes commented Jan 28, 2024

Hi there, we do not use plain HTML, CSS, or JavaScript - We have initially used ReactJS with Bootstrap. And would like to keep it that way. However, there might be multiple issues if we were to add a dark mode right now. Anyways do add a dark mode to one single page, let us see how that works out, and then we can go ahead with the same.

Important

Make sure you make the PR to the beta branch, not main

📑 Checklist

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. JWOC medium and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Jan 28, 2024
@Pranathi2011
Copy link

Pranathi2011 commented Feb 2, 2024

Hi @tamalCodes , I have made PR to the main branch by mistake, what to do now?

@Surajit0573 Surajit0573 removed their assignment Feb 3, 2024
@riteshshukladev
Copy link

Hey @tamalCodes , would love to add this test feature of Light and dark mode as a test on one of the pages, Kindly assign (if not assigned to some other fellow coder).

@tamalCodes
Copy link
Member

Hi @riteshshukladev this was assigned to @Pranathi2011 previously but looks like they are inactive right now - so would be better if you could go ahead and do it. Remember to take a look at other sites for more information on how to add dark mode or what colors can be added for the same.

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@github-project-automation github-project-automation bot moved this from Todo to Merged/Discarded in Milan Feb 20, 2024
@tamalCodes tamalCodes added the invite me to the organisation Sends an invitation to your community organisation. label Mar 12, 2024
Copy link

Hi @tamalCodes, We just made a new organization, and have sent you an invite. Welcome to the community 🎉

Don't forget after accepting to make it public so it appears on your GitHub profile for everyone else to see. You can do this by finding your name in the GitHub organisation list and change the dropdown to public https://github.com/orgs/MilanCommunity/people

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature This generally contains addition/changes to features. invite me to the organisation Sends an invitation to your community organisation. JWOC medium status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: Merged/Discarded
Development

No branches or pull requests

4 participants