Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Signup Button Loader Runs Without Email and Password Input #1258

Closed
3 of 5 tasks
st17931 opened this issue Aug 28, 2024 · 4 comments
Closed
3 of 5 tasks

Bug: Signup Button Loader Runs Without Email and Password Input #1258

st17931 opened this issue Aug 28, 2024 · 4 comments
Labels
🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.

Comments

@st17931
Copy link

st17931 commented Aug 28, 2024

Description

The loader on the Signup button is triggered even when there are no values entered in the email and password fields. This behavior is unexpected, as the loader should only activate when the user has entered valid data and submitted the form.

Steps to Reproduce:

  1. Navigate to the Signup page.
    
  2. Leave the email and password fields empty.
    
  3. Click on the Signup button.
    

Expected Behavior: The Signup button should only show the loader when valid inputs are provided and the form is submitted.

Actual Behavior: The loader is activated immediately upon clicking the Signup button, regardless of whether the email and password fields are filled.

Impact: This bug may confuse users as it suggests that the signup process has started when it has not.

Proposed Solution

To resolve this issue, we will implement the following changes:

Remove Loader on Empty Fields:
We will modify the logic to ensure that the loader does not run when the email and password fields are empty. This will prevent unnecessary loading indicators when the form is incomplete.

Trigger Loader on Valid Input:
The loader will be activated only when both the email and password fields have valid input and the user submits the form. This ensures that the loading state reflects the actual processing of the signup request.

Form Validation:
Before triggering the loader, the form will be validated to check if the required fields (email and password) are filled. If validation passes, the loader will be triggered; otherwise, an appropriate error message will be displayed without initiating the loader.

Screenshots

Signup_page_issue.webm
Signup_loader_issue

Browser 🥦

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no).
@st17931 st17931 added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Aug 28, 2024
@github-project-automation github-project-automation bot moved this to Todo in Milan Aug 28, 2024
Copy link

Hello @st17931, thank you for raising the issue.

Currently, the issue is marked as status: todo ⏳ This issue is yet to be seen by the maintainer of the project. so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at tamalcodes@gmail.com if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Nirpendra09
Copy link

Hi @tamalCodes can you assign this to me?

@shreya-mangade
Copy link

Hello @tamalCodes ,
Can you please assign this issue to me?

@r0ld3x
Copy link

r0ld3x commented Sep 28, 2024

@tamalCodes hey can you assign me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project.
Projects
Status: Merged/Discarded
Development

No branches or pull requests

5 participants