fix(store): add immutability check for IE compatibility (#1997)

IE errors when attempting to access the `caller` property of a function, so rearrange the freeze function to check for this first. Fixes #1991
ngrx · Jul 5, 2019 · 11c0864 · 11c0864
1 parent 2b8178d
commit 11c0864
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/modules/store/src/meta-reducers/immutability_reducer.ts b/modules/store/src/meta-reducers/immutability_reducer.ts
@@ -20,16 +20,20 @@ function freeze(target: any) {
   const targetIsFunction = isFunction(target);
 
   Object.getOwnPropertyNames(target).forEach(prop => {
-    const propValue = target[prop];
     if (
       hasOwnProperty(target, prop) &&
       (targetIsFunction
         ? prop !== 'caller' && prop !== 'callee' && prop !== 'arguments'
-        : true) &&
-      (isObjectLike(propValue) || isFunction(propValue)) &&
-      !Object.isFrozen(propValue)
+        : true)
     ) {
-      freeze(propValue);
+      const propValue = target[prop];
+
+      if (
+        (isObjectLike(propValue) || isFunction(propValue)) &&
+        !Object.isFrozen(propValue)
+      ) {
+        freeze(propValue);
+      }
     }
   });