fix(data): DefaultDataService getAll httpOptions fix + test (#4134)

Co-authored-by: thomas <t.welsch@wsa-electronic.de>
ngrx · Nov 19, 2023 · 213e4c9 · 213e4c9
1 parent 9c8304a
commit 213e4c9
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/modules/data/spec/dataservices/default-data.service.spec.ts b/modules/data/spec/dataservices/default-data.service.spec.ts
@@ -216,6 +216,22 @@ describe('DefaultDataService', () => {
 
       req.error(errorEvent, { status: 404, statusText: 'Not Found' });
     });
+
+    it('should pass httpOptions', (done) => {
+      const expectedParams = new HttpParams({ fromObject: { test: 123 } });
+      service
+        .getAll({ httpParams: { fromObject: { test: 123 } } })
+        .subscribe((heroes) => {
+          expect(heroes.length).toEqual(0);
+          done();
+        }, fail);
+
+      const req = httpTestingController.expectOne(heroesUrl + '?test=123');
+
+      expect(req.request.params).toEqual(expectedParams);
+
+      req.flush([]); // Respond with no heroes
+    });
   });
 
   describe('#getById', () => {

diff --git a/modules/data/src/dataservices/default-data.service.ts b/modules/data/src/dataservices/default-data.service.ts
@@ -98,7 +98,7 @@ export class DefaultDataService<T> implements EntityCollectionDataService<T> {
   }
 
   getAll(options?: HttpOptions): Observable<T[]> {
-    return this.execute('GET', this.entitiesUrl, null, options);
+    return this.execute('GET', this.entitiesUrl, null, null, options);
   }
 
   getById(key: number | string, options?: HttpOptions): Observable<T> {