feat(component-store): handle errors in next callback (#3533)

ngrx · Aug 16, 2022 · 551c8eb · 551c8eb
1 parent 1a906fd
commit 551c8eb
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/modules/component-store/spec/tap-response.spec.ts b/modules/component-store/spec/tap-response.spec.ts
@@ -22,6 +22,19 @@ describe('tapResponse', () => {
     expect(errorCallback).toHaveBeenCalledWith(error);
   });
 
+  it('should invoke error callback on the exception thrown in next', () => {
+    const errorCallback = jest.fn<void, [{ message: string }]>();
+    const error = { message: 'error' };
+
+    function producesError() {
+      throw error;
+    }
+
+    of(1).pipe(tapResponse(producesError, errorCallback)).subscribe();
+
+    expect(errorCallback).toHaveBeenCalledWith(error);
+  });
+
   it('should invoke complete callback on complete', () => {
     const completeCallback = jest.fn<void, []>();
 

diff --git a/modules/component-store/src/tap-response.ts b/modules/component-store/src/tap-response.ts
@@ -31,9 +31,11 @@ export function tapResponse<T, E = unknown>(
     source.pipe(
       tap({
         next: nextFn,
-        error: errorFn,
         complete: completeFn,
       }),
-      catchError(() => EMPTY)
+      catchError((e) => {
+        errorFn(e);
+        return EMPTY;
+      })
     );
 }