fix(component): detect zone.js using instanceof comparison (#2547)

modules/component/spec/core/utils/has-zone.spec.ts

@@ -0,0 +1,42 @@
+import { hasZone } from '../../../src/core/utils/has-zone';
+import { ApplicationRef, Component, NgModule, NgZone } from '@angular/core';
+import { NoopAnimationsModule } from '@angular/platform-browser/animations';
+import { getTestBed } from '@angular/core/testing';
+
+describe('hasZone', () => {
+  async function setup({ defaultZone }: { defaultZone: boolean }) {
+    @Component({
+      selector: 'body',
+      template: '<div></div>',
+    })
+    class NgZoneTestComponent {
+      checkNgZone = hasZone(this.ngZone);
+      constructor(readonly ngZone: NgZone) {}
+    }
+
+    @NgModule({
+      declarations: [NgZoneTestComponent],
+      exports: [NgZoneTestComponent],
+      bootstrap: [NgZoneTestComponent],
+      imports: [NoopAnimationsModule],
+    })
+    class MyAppModule {}
+
+    const platform = getTestBed().platform;
+    const moduleRef = defaultZone
+      ? await platform.bootstrapModule(MyAppModule)
+      : await platform.bootstrapModule(MyAppModule, { ngZone: 'noop' });
+    const appRef = moduleRef.injector.get(ApplicationRef);
+    const testComp = appRef.components[0].instance;
+
+    return { hasZone: testComp.checkNgZone };
+  }
+
+  it('returns false when default zone is used', async () => {
+    expect(await setup({ defaultZone: true })).toEqual({ hasZone: true });
+  });
+
+  it('returns true when noop zone is chosen', async () => {
+    expect(await setup({ defaultZone: false })).toEqual({ hasZone: false });
+  });
+});

modules/component/spec/fixtures/fixtures.ts

@@ -1,13 +1,7 @@
 import createSpy = jasmine.createSpy;
-import { ChangeDetectorRef } from '@angular/core';
-import { MockNgZone } from './mock-ng-zone';
+import { ChangeDetectorRef, NgZone } from '@angular/core';
 import { MockNoopNgZone } from './mock-noop-ng-zone';
 
-/**
- * this is not exposed as NgZone should never be exposed to get miss matched with the real one
- */
-class NgZone extends MockNgZone {}
-
 /**
  * this is not exposed as NgZone should never be exposed to get miss matched with the real one
  */

modules/component/src/core/cd-aware/creator_render.ts

@@ -1,5 +1,5 @@
 import { ChangeDetectorRef, NgZone } from '@angular/core';
-import { isNgZone } from '../utils';
+import { hasZone } from '../utils';
 
 export interface RenderConfig {
   ngZone: NgZone;
@@ -8,7 +8,7 @@ export interface RenderConfig {
 
 export function createRender<T>(config: RenderConfig): () => void {
   function render() {
-    if (isNgZone(config.ngZone)) {
+    if (hasZone(config.ngZone)) {
       config.cdRef.markForCheck();
     } else {
       config.cdRef.detectChanges();

modules/component/src/core/utils/has-zone.ts

@@ -14,5 +14,5 @@ import { NgZone } from '@angular/core';
  * ```
  */
 export function hasZone(z: NgZone): boolean {
-  return z.constructor.name !== 'NoopNgZone';
+  return z instanceof NgZone;
 }

modules/component/src/core/utils/index.ts

@@ -1,3 +1,3 @@
 export * from './get-global-this';
-export * from './zone-checks';
+export * from './has-zone';
 export * from './is-ivy';