fix(schematics): correct module while generating a feature (#4289)

Closes #4281
ngrx · Apr 8, 2024 · 7ecffe8 · 7ecffe8
1 parent 092076c
commit 7ecffe8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/modules/schematics/src/effect/index.ts b/modules/schematics/src/effect/index.ts
@@ -115,17 +115,15 @@ function getEffectStart(name: string, effectPrefix: string): string {
 export default function (options: EffectOptions): Rule {
   return (host: Tree, context: SchematicContext) => {
     options.path = getProjectPath(host, options);
-
+    const parsedPath = parseName(options.path, options.name || '');
+    options.name = parsedPath.name;
+    options.path = parsedPath.path;
     options.prefix = getPrefix(options);
 
     if (options.module) {
       options.module = findModuleFromOptions(host, options);
     }
 
-    const parsedPath = parseName(options.path, options.name || '');
-    options.name = parsedPath.name;
-    options.path = parsedPath.path;
-
     const templateSource = apply(url('./files'), [
       options.skipTests
         ? filter((path) => !path.endsWith('.spec.ts.template'))

diff --git a/modules/schematics/src/feature/index.spec.ts b/modules/schematics/src/feature/index.spec.ts
@@ -183,7 +183,7 @@ describe('Feature Schematic', () => {
       ...defaultOptions,
       name: 'foo/Foo',
       group: true,
-      module: 'app',
+      module: '../app',
     };
 
     const tree = await schematicRunner.runSchematic(

diff --git a/modules/schematics/src/reducer/index.ts b/modules/schematics/src/reducer/index.ts
@@ -30,17 +30,16 @@ export default function (options: ReducerOptions): Rule {
   return (host: Tree, context: SchematicContext) => {
     const projectConfig = getProject(host, options);
     options.path = getProjectPath(host, options);
-
     options.prefix = getPrefix(options);
 
-    if (options.module) {
-      options.module = findModuleFromOptions(host, options);
-    }
-
     const parsedPath = parseName(options.path, options.name);
     options.name = parsedPath.name;
     options.path = parsedPath.path;
 
+    if (options.module) {
+      options.module = findModuleFromOptions(host, options);
+    }
+
     const templateOptions = {
       ...stringUtils,
       'if-flat': (s: string) =>