feat(entity): remove addAll (#2783)

* feat(entity): remove deprecated addAll

BREAKING CHANGE:

To overwrite the entities, we previously used the `addAll` method but the method name was confusing.

BEFORE:

```ts
adapter.addAll(action.entities, state);
```

AFTER:

The new method name `setAll` describes the intention better.

```ts
adapter.setAll(action.entities, state);
```

* refactor(data): use the setAll adapter method

modules/data/spec/reducers/entity-collection-reducer.spec.ts

@@ -2520,7 +2520,7 @@ describe('EntityCollectionReducer', () => {
 
           case EntityOp.QUERY_LOAD_SUCCESS:
             return {
-              ...adapter.addAll(action.payload.data, collection),
+              ...adapter.setAll(action.payload.data, collection),
               loaded: true,
               loading: false,
               changeState: {},

modules/data/src/reducers/entity-collection-reducer-methods.ts

@@ -257,7 +257,7 @@ export class EntityCollectionReducerMethods<T> {
   ): EntityCollection<T> {
     const data = this.extractData(action);
     return {
-      ...this.adapter.addAll(data, collection),
+      ...this.adapter.setAll(data, collection),
       loading: false,
       loaded: true,
       changeState: {},
@@ -943,7 +943,7 @@ export class EntityCollectionReducerMethods<T> {
   ): EntityCollection<T> {
     const entities = this.guard.mustBeEntities(action);
     return {
-      ...this.adapter.addAll(entities, collection),
+      ...this.adapter.setAll(entities, collection),
       loading: false,
       loaded: true,
       changeState: {},

modules/entity/spec/sorted_state_adapter.spec.ts

@@ -86,23 +86,6 @@ describe('Sorted State Adapter', () => {
     });
   });
 
-  it('should remove existing and add new ones on addAll (deprecated)', () => {
-    const withOneEntity = adapter.addOne(TheGreatGatsby, state);
-
-    const withAll = adapter.setAll(
-      [AClockworkOrange, AnimalFarm],
-      withOneEntity
-    );
-
-    expect(withAll).toEqual({
-      ids: [AClockworkOrange.id, AnimalFarm.id],
-      entities: {
-        [AClockworkOrange.id]: AClockworkOrange,
-        [AnimalFarm.id]: AnimalFarm,
-      },
-    });
-  });
-
   it('should let you add remove an entity from the state', () => {
     const withOneEntity = adapter.addOne(TheGreatGatsby, state);
 

modules/entity/spec/unsorted_state_adapter.spec.ts

@@ -85,23 +85,6 @@ describe('Unsorted State Adapter', () => {
     });
   });
 
-  it('should remove existing and add new ones on addAll (deprecated)', () => {
-    const withOneEntity = adapter.addOne(TheGreatGatsby, state);
-
-    const withAll = adapter.addAll(
-      [AClockworkOrange, AnimalFarm],
-      withOneEntity
-    );
-
-    expect(withAll).toEqual({
-      ids: [AClockworkOrange.id, AnimalFarm.id],
-      entities: {
-        [AClockworkOrange.id]: AClockworkOrange,
-        [AnimalFarm.id]: AnimalFarm,
-      },
-    });
-  });
-
   it('should let you add remove an entity from the state', () => {
     const withOneEntity = adapter.addOne(TheGreatGatsby, state);
 

modules/entity/src/models.ts

@@ -55,9 +55,6 @@ export interface EntityStateAdapter<T> {
   addOne<S extends EntityState<T>>(entity: T, state: S): S;
   addMany<S extends EntityState<T>>(entities: T[], state: S): S;
 
-  /** @deprecated addAll has been renamed. Use setAll instead. */
-  addAll<S extends EntityState<T>>(entities: T[], state: S): S;
-
   setAll<S extends EntityState<T>>(entities: T[], state: S): S;
   setOne<S extends EntityState<T>>(entity: T, state: S): S;
 

modules/entity/src/sorted_state_adapter.ts

@@ -231,7 +231,6 @@ export function createSortedStateAdapter<T>(selectId: any, sort: any): any {
     addOne: createStateOperator(addOneMutably),
     updateOne: createStateOperator(updateOneMutably),
     upsertOne: createStateOperator(upsertOneMutably),
-    addAll: createStateOperator(setAllMutably),
     setAll: createStateOperator(setAllMutably),
     setOne: createStateOperator(setOneMutably),
     addMany: createStateOperator(addManyMutably),

modules/entity/src/unsorted_state_adapter.ts

@@ -230,7 +230,6 @@ export function createUnsortedStateAdapter<T>(selectId: IdSelector<T>): any {
     removeAll,
     addOne: createStateOperator(addOneMutably),
     addMany: createStateOperator(addManyMutably),
-    addAll: createStateOperator(setAllMutably),
     setAll: createStateOperator(setAllMutably),
     setOne: createStateOperator(setOneMutably),
     updateOne: createStateOperator(updateOneMutably),