feat(store): use createFeature in feature schematics (#3776)

Closes #3741
ngrx · Feb 27, 2023 · 9b3647f · 9b3647f
1 parent 6219fec
commit 9b3647f
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 10 deletions.
diff --git a/...ty/files/__name@dasherize@if-flat__/__name@dasherize@group-reducers__.reducer.ts.template b/...ty/files/__name@dasherize@if-flat__/__name@dasherize@group-reducers__.reducer.ts.template
@@ -1,4 +1,4 @@
-import { Action, createReducer, on } from '@ngrx/store';
+import { createFeature, createReducer, on } from '@ngrx/store';
 import { EntityState, EntityAdapter, createEntityAdapter } from '@ngrx/entity';
 import { <%= classify(name) %> } from '<%= featurePath(group, flat, "models", dasherize(name)) %><%= dasherize(name) %>.model';
 import * as <%= classify(name) %>Actions from '<%= featurePath(group, flat, "actions", dasherize(name)) %><%= dasherize(name) %>.actions';
@@ -49,9 +49,17 @@ export const reducer = createReducer(
   ),
 );
 
+export const <%= pluralize(name) %>Feature = createFeature({
+  name: <%= pluralize(name) %>FeatureKey,
+  reducer,
+  extraSelectors: ({ select<%= capitalize(pluralize(name)) %>State }) => ({
+    ...adapter.getSelectors(select<%= capitalize(pluralize(name)) %>State)
+  }),
+});
+
 export const {
   selectIds,
   selectEntities,
   selectAll,
   selectTotal,
-} = adapter.getSelectors();
+} = <%= pluralize(name) %>Feature;
diff --git a/...atics/src/reducer/files/__name@dasherize@if-flat__/__name@dasherize__.reducer.ts.template b/...atics/src/reducer/files/__name@dasherize@if-flat__/__name@dasherize__.reducer.ts.template
@@ -1,5 +1,5 @@
-import { Action, createReducer, on } from '@ngrx/store';
-<% if(feature) { %>import * as <%= classify(name) %>Actions from '<%= featurePath(group, flat, "actions", dasherize(name)) %><%= dasherize(name) %>.actions';<% } %>
+import {<% if(feature) { %> createFeature,<% } %> createReducer, on } from '@ngrx/store';
+import * as <%= classify(name) %>Actions from '<%= featurePath(group, flat, "actions", dasherize(name)) %><%= dasherize(name) %>.actions';
 
 export const <%= camelize(name) %>FeatureKey = '<%= camelize(name) %>';
 
@@ -12,10 +12,14 @@ export const initialState: State = {
 };
 
 export const reducer = createReducer(
-  initialState,
-<% if(feature) { %>
+  initialState,<% if(feature) { %>
   on(<%= classify(name) %>Actions.<%= prefix %><%= classify(name) %>s, state => state),
 <% if(api) { %>  on(<%= classify(name) %>Actions.<%= prefix %><%= classify(name) %>sSuccess, (state, action) => state),
-  on(<%= classify(name) %>Actions.<%= prefix %><%= classify(name) %>sFailure, (state, action) => state),
-<% } %><% } %>
+  on(<%= classify(name) %>Actions.<%= prefix %><%= classify(name) %>sFailure, (state, action) => state),<% } %><% } %>
 );
+<% if(feature) { %>
+export const <%= camelize(name) %>Feature = createFeature({
+  name: <%= camelize(name) %>FeatureKey,
+  reducer,
+});
+<% } %>
diff --git a/modules/schematics/src/reducer/index.spec.ts b/modules/schematics/src/reducer/index.spec.ts
@@ -111,7 +111,9 @@ describe('Reducer Schematic', () => {
         `${projectPath}/src/app/foo.reducer.ts`
       );
 
-      expect(fileContent).toMatch(/export const reducer = createReducer\(/);
+      expect(fileContent).toMatch(/export const fooFeature = createFeature\(/);
+      expect(fileContent).toMatch(/name: fooFeatureKey,/);
+      expect(fileContent).toMatch(/= createReducer\(/);
       expect(fileContent).toMatch(/on\(FooActions.loadFoos, state => state\)/);
     });
 
@@ -127,7 +129,9 @@ describe('Reducer Schematic', () => {
         `${projectPath}/src/app/foo.reducer.ts`
       );
 
-      expect(fileContent).toMatch(/export const reducer = createReducer\(/);
+      expect(fileContent).toMatch(/export const fooFeature = createFeature\(/);
+      expect(fileContent).toMatch(/name: fooFeatureKey,/);
+      expect(fileContent).toMatch(/= createReducer\(/);
       expect(fileContent).toMatch(/on\(FooActions.loadFoos, state => state\)/);
       expect(fileContent).toMatch(
         /on\(FooActions.loadFoosSuccess, \(state, action\) => state\)/