Skip to content

Commit

Permalink
fix: Declare global NgRx packages for UMD bundles (#952)
Browse files Browse the repository at this point in the history
Closes #949
  • Loading branch information
MikeRyanDev authored and brandonroberts committed Apr 2, 2018
1 parent f1751fa commit ba2139d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tools/defaults.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ NGRX_SCOPED_PACKAGES = ["@ngrx/%s" % p for p in [
"store-devtools",
]]

NGRX_GLOBALS = dict({
"tslib": "tslib",
}, **{p: p for p in NGRX_SCOPED_PACKAGES})

PKG_GROUP_REPLACEMENTS = {
"NG_VERSION": NG_VERSION,
"RXJS_VERSION": RXJS_VERSION,
Expand Down Expand Up @@ -65,8 +69,6 @@ def ng_package(name, readme_md=None, license_banner=None, globals={}, **kwargs):
name=name,
readme_md=readme_md,
license_banner=license_banner,
globals=dict(globals, **{
"tslib": "tslib"
}),
globals=dict(globals, **NGRX_GLOBALS),
replacements=PKG_GROUP_REPLACEMENTS,
**kwargs)

0 comments on commit ba2139d

Please sign in to comment.