Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StoreDevtools): Refresh devtools when extension is started #1017

Merged
merged 2 commits into from
May 9, 2018
Merged

fix(StoreDevtools): Refresh devtools when extension is started #1017

merged 2 commits into from
May 9, 2018

Conversation

nasreddineskandrani
Copy link
Contributor

@nasreddineskandrani nasreddineskandrani commented May 5, 2018

Description

hi!
this is a fix for #508 (#966)

solution:
basically i subscribe to the devtools-extension start action and i trigger an action refresh to rerender as is the state transformations

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 93.111% when pulling be9b54d on nasreddineskandrani:fix/devtools into 51eb9d4 on ngrx:master.

@@ -427,6 +427,7 @@ export function liftReducerWith(

break;
}
case Actions.REFRESH:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case isn't needed since its an unknown action.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right! i saw that you did the change already thanks!

@brandonroberts brandonroberts changed the title fix(store-devtools) no store found if app already running fix(StoreDevtools): Refresh devtools when extension is started May 9, 2018
@brandonroberts brandonroberts merged commit c6e33d9 into ngrx:master May 9, 2018
@brandonroberts
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants