Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Store): deprecate projector selector #1580

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Deprecates the overload that will be removed in #1579

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 89.43% when pulling 5a411ff on pr/deprecate-selector into 5fbcb3c on master.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 26, 2019

Preview docs changes for 5a411ff at https://previews.ngrx.io/pr1580-5a411ff/

@brandonroberts brandonroberts merged commit e86c5f6 into master Feb 27, 2019
@brandonroberts brandonroberts deleted the pr/deprecate-selector branch February 27, 2019 01:05
tja4472 pushed a commit to tja4472/platform that referenced this pull request Mar 20, 2019
@timdeschryver timdeschryver restored the pr/deprecate-selector branch March 27, 2019 21:35
@timdeschryver timdeschryver deleted the pr/deprecate-selector branch March 27, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants