Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): add the missing bracket #1721

Merged
merged 4 commits into from
Apr 10, 2019
Merged

fix(store): add the missing bracket #1721

merged 4 commits into from
Apr 10, 2019

Conversation

alex-okrushko
Copy link
Member

@alex-okrushko alex-okrushko commented Apr 9, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Remove true && which is always true.

add the bracket

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@alex-okrushko alex-okrushko changed the title refactor(store): remove redundant code fix(store): add the missing bracket Apr 9, 2019
@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 9, 2019

Preview docs changes for 75fdc92 at https://previews.ngrx.io/pr1721-75fdc92/

@timdeschryver
Copy link
Member

For full coverage a change the invoke function at

function invokeReducer(reduce: Function) {

To be

function invokeReducer(reduce: Function) {
      immutabilityCheckMetaReducer((state, action) => {
        reduce(action);
        return state;
      })({}, { type: 'invoke', numbers: [1, 2, 3], fun: function() {} });
}

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 9, 2019

Preview docs changes for 27c3668 at https://previews.ngrx.io/pr1721-27c3668/

@alex-okrushko
Copy link
Member Author

Done.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 9, 2019

Preview docs changes for c84723e at https://previews.ngrx.io/pr1721-c84723e/

@ngrxbot
Copy link
Collaborator

ngrxbot commented Apr 9, 2019

Preview docs changes for 1fa74e3 at https://previews.ngrx.io/pr1721-1fa74e3/

@brandonroberts brandonroberts merged commit 56f8a59 into ngrx:master Apr 10, 2019
@alex-okrushko alex-okrushko deleted the meta-reducer branch October 30, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants