Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Test-View not visible #1868

Closed
negue opened this issue May 17, 2019 · 17 comments
Closed

DevTools: Test-View not visible #1868

negue opened this issue May 17, 2019 · 17 comments
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Router Store

Comments

@negue
Copy link

negue commented May 17, 2019

Minimal reproduction of the bug/regression with instructions:

  1. Add StoreDevtoolsModule to your Module
      StoreDevtoolsModule.instrument({
         logOnly: true,
         // also tested with features: { test: true }
      }),
  1. Open DevTools in the Browser
  2. No Test-View available

Go to: https://ngrx-seed.stackblitz.io/ and open your DevTools and see that there is no Test-View visible

But, if you open the edit view of stackblitz (https://stackblitz.com/edit/ngrx-seed?file=src%2Fapp%2Fapp.module.ts) you can see that Stackblitz's own redux? does add the Test-View 😅

Expected behavior:

Have a Test-View like its visible on other sites.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

NGRX 7.4.0
Angular 7.2.13
Browsers: Chrome and Firefox

Other information:

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[x] No

@adrianfaciu
Copy link

Cannot reproduce this. If I go to the StackBlitz example, the instance is visible in DevTools. Both router and counter properties are present.

@negue
Copy link
Author

negue commented May 17, 2019

DevTools Views

with NgRx Seed:
image

with Stackblitz itself:
image

As you see Trace and Test are missing

@adrianfaciu
Copy link

Yeah, there is something here. If I open dev tools and have a look they are there:

Screenshot 2019-05-17 at 20 34 34

However, if I refresh the page they dissapear. Closing and opening dev tools again will make them show up.

@negue
Copy link
Author

negue commented May 17, 2019

I don't get any on the NgRx Seed, using Vivaldi / Chrome on both Mac and Windows. 🙁

Both browser have the latest version of the dev tools installed

@timdeschryver
Copy link
Member

timdeschryver commented May 18, 2019

Weird that you see this @adrianfaciu, it shouldn't show up AFAIK.

To have these features available we must identify ourselves as a redux app, see https://github.com/zalmoxisus/redux-devtools-extension/blob/master/npm-package/logOnly.js#L9 for ref.

For us, this would mean adding a type property at

private getExtensionConfig(config: StoreDevtoolsConfig) {

I tried it locally and the redux features become visible but sadly enough, will do nothing.

image

@adrianfaciu
Copy link

Hmm, that is weird.
If no one else is working on it, I can pick it up next and try to sort it out.

@timdeschryver
Copy link
Member

Yes, that's fine by me Adrian thanks!

@timdeschryver timdeschryver added the community watch Someone from the community is working this issue/PR label May 21, 2019
@dummdidumm
Copy link
Contributor

dummdidumm commented May 29, 2019

About the "lib redux" issue, I ran into this problem as well, and it's basically a bug in the redux devtools zalmoxisus/remotedev-app#40

@timdeschryver
Copy link
Member

@dummdidumm We can make it a redux app, #1868 (comment)

But then you're getting some other problems 😂

@adrianfaciu
Copy link

adrianfaciu commented May 30, 2019

Sorry for the delay, I traveled a lot lately and did not have time. I'll pick this up in the weekend and see what can be done.

@alex-vg
Copy link

alex-vg commented Mar 19, 2020

ngrx race
A little update here, I just tried setting trace=true and type='redux' and got some traces. Not enough to see the origin but somewhat useful.

Edit: a Error.stackTraceLimit=100 fixed it

@montogeek
Copy link

@alex-vg How did you activate Trace tab?

@minijus
Copy link
Contributor

minijus commented May 6, 2021

While there is still no support for traces in @ngrx/store-devtools, one can add a breakpoint on dispatch method to have some traceability.

image

@Rybadour
Copy link

Rybadour commented Sep 7, 2021

@brandonroberts

Why was this closed? I don't see any resolutions to the problem and as of the 12.4.0 I still can't access the trace tab.

@alex-vg
Copy link

alex-vg commented Sep 14, 2021

@brandonroberts
Is there a fix for this issue coming?
Seeing such an important feature closed without a resolution seems odd.

@thompsonap09
Copy link

Has anybody figured out how to handle this? It looks like @adrianfaciu was working on it at one point and @alex-vg seems to have figured out how to at least make it work a bit

@JoannaFalkowska
Copy link

Any updates or tips on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepting PRs community watch Someone from the community is working this issue/PR enhancement Project: Router Store
Projects
None yet
Development

No branches or pull requests