Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): split Immutable checks in state and action checks #1894

Merged
merged 1 commit into from
May 28, 2019

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #1890

What is the new behavior?

Does this PR introduce a breaking change?

A breaking change for v8 beta

[x] Yes
[ ] No
runtimeChecks: {
-  strictImmutability: true,
+  strictStateImmutability: true,
+  strictActionImmutability: true,
   strictStateSerializability: true,
   strictActionSerializability: true,
},

@brandonroberts brandonroberts merged commit c59c211 into master May 28, 2019
@brandonroberts brandonroberts deleted the pr/immutability-checks branch May 28, 2019 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

splitting up strictImmutability into separate store/action checks
2 participants