-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(schematics): toggle immutability checks for root by default #1983
refactor(schematics): toggle immutability checks for root by default #1983
Conversation
@timdeschryver What do you think about adding the |
Preview docs changes for 58f4fd3 at https://previews.ngrx.io/pr1983-58f4fd3/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think immutability is important, serializability isn't always needed and might backfire if you aren't careful. For now, I would leave it as it is.
Do you also want to add the schematic in the docs at https://ngrx.io/guide/schematics/store?
Feel free to ping me if you need some help.
I don't think we need another flag for this. It's a reasonable default and is easy enough to remove. |
Sure, I will update the docs thanks :) 👍 |
@brandonroberts I have removed the flag as you suggested |
Preview docs changes for 0f384b0 at https://previews.ngrx.io/pr1983-0f384b0/ |
@timdeschryver after removing the flag there is no need to update the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
when use schematics
forRoot
toggle runtime checks by default.Closes #1950
Does this PR introduce a breaking change?