feat(store): add refreshState method to mock store #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for 45b5327 at https://previews.ngrx.io/pr2148-45b5327/ |
The MockStore.refreshState() method emits a clone of the existing state on the store observable, that will cause the selectors to recompute. This enables multiple calls of setResult for mocked selectors during testing. Also fixes a bug with store.select not refreshing mocked selectors Closes #2121
brandonroberts
force-pushed
the
mock-store-refresh
branch
from
45b5327 to
603e09e
Compare
|
Preview docs changes for 603e09e at https://previews.ngrx.io/pr2148-603e09e/ |
|
cc: @tomastrajan. I tested these changes against your repo and it resolved the issue |
|
@brandonroberts thx mate, sounds amazing ! |
|
Preview docs changes for a1f987d at https://previews.ngrx.io/pr2148-a1f987d/ |
timdeschryver
approved these changes
Oct 6, 2019
jordanpowell88
pushed a commit
to jordanpowell88/platform
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MockStore.refreshState() method emits a clone of the existing
state on the state observable, that will cause the selectors to recompute.
This enables multiple calls of setResult for mocked selectors during testing.
Also fixes a bug with store.select not refreshing mocked selectors
Closes #2121
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #2121
What is the new behavior?
Does this PR introduce a breaking change?
Other information