Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): ignore ngrx actions for runtime checks #2351

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

timdeschryver
Copy link
Member

@timdeschryver timdeschryver commented Feb 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2109

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This only skips the checks on the action.
The state checks remain as is.

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 6, 2020

Preview docs changes for 02bd8d7 at https://previews.ngrx.io/pr2351-02bd8d7/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core.js:5760 ERROR TypeError: Cannot assign to read only property 'tView' of object '[object Object]'
3 participants