Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): testing - clean up mock store a bit #2361

Merged
merged 4 commits into from
Feb 17, 2020
Merged

feat(store): testing - clean up mock store a bit #2361

merged 4 commits into from
Feb 17, 2020

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Add tests that would consistently catch resetSelectors in afterEach
  • Make selectors private, instead of static
  • cleanup constructor
  • remove function overloads for overrideSelector - can we typed all at once
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

MockStore.selectors is not longer static or visible. I don't think that's the API that we meant to support to begin with.

[x] Yes
[ ] No

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Feb 10, 2020

Preview docs changes for 43f58a7 at https://previews.ngrx.io/pr2361-43f58a7/

@brandonroberts
Copy link
Member

brandonroberts commented Feb 13, 2020

@alex-okrushko will you take a look at why the example app tests are failing? I'd like to land this before we cut another beta

@alex-okrushko
Copy link
Member Author

@alex-okrushko will you take a look at why the example app tests are failing? I'd like to land this before we cut another beta

Yes. Looking into it right now

@brandonroberts brandonroberts merged commit ee2c114 into ngrx:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants