Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about "The feature name \"${featureName}\" does not exist" creates a lot of noise in tests #2400

Closed
alex-okrushko opened this issue Feb 19, 2020 · 1 comment
Labels
Need Discussion Request For Comment needs input Project: Store

Comments

@alex-okrushko
Copy link
Member

When running tests this message happens a lot:

`@ngrx/store: The feature name \"${featureName}\" does ` +
'not exist in the state, therefore createFeatureSelector ' +
'cannot access it. Be sure it is imported in a loaded module ' +
`using StoreModule.forRoot('${featureName}', ...) or ` +
`StoreModule.forFeature('${featureName}', ...). If the default ` +
'state is intended to be undefined, as is the case with router ' +
'state, this development-only warning message can be ignored.'

Prior issue: #2116

Minimal reproduction of the bug/regression with instructions:

Expected behavior:

I think we should remove it.

I would be willing to submit a PR to fix this issue

[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No

@alex-okrushko alex-okrushko added Project: Store Need Discussion Request For Comment needs input labels Feb 19, 2020
@alex-okrushko
Copy link
Member Author

I'll close this one in favor of #2363 which is exactly the same :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Need Discussion Request For Comment needs input Project: Store
Projects
None yet
Development

No branches or pull requests

1 participant