-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add ngrxPush migration #2452
Conversation
3fd4e90
to
e950936
Compare
@@ -17,6 +18,170 @@ export function visitTSSourceFiles<Result = void>( | |||
return result; | |||
} | |||
|
|||
export function visitTemplates( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the most interesting part of the PR
Preview docs changes for 5c31542 at https://previews.ngrx.io/pr2452-5c31542/ |
Won't this break their existing app/tests due to missing |
I didn't think of that, but you're right @brandonroberts ! |
Some options that I think of are:
Regardless of the decision we make, I would like to ask to review the template visitor as this may be useful for future migrations? |
The template visitor code looks good to me. I don't have a strong choice on the options, as modifying all the modules is a bit heavy-handed, and if you're providing the modules to change, you might as well have added the import manually(assuming you have fine-grained modules). |
Circling back on this, we could add |
Sorry, I forgot about this PR... What you're saying makes sense! |
c991446
to
9bc4b63
Compare
9bc4b63
to
5c31542
Compare
@brandonroberts it was also needed to check for |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes the first todo of #2450
What is the new behavior?
This PR adds a
visitTemplates
method to schematics-core to find all templates (inline and as a file).For the migration, it creates a new
ngrx-push-migration
schematic.Does this PR introduce a breaking change?
Other information
Implementation is inspired by angular material.