Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-store): selects should return selectors #2517

Merged
merged 2 commits into from
May 8, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2516

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

This time with tests... 🤦‍♂️

@ngrxbot
Copy link
Collaborator

ngrxbot commented May 7, 2020

Preview docs changes for eef5e91 at https://previews.ngrx.io/pr2517-eef5e91/

@timdeschryver timdeschryver changed the title Pr/router selector interface fix(router-store): selects should return selectors May 7, 2020
@brandonroberts brandonroberts merged commit 831e1e4 into master May 8, 2020
@brandonroberts brandonroberts deleted the pr/router-selector-interface branch May 8, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect typings on router-state selectors
3 participants