feat(effects): allow multiple empty EffectModule.forRoot() #2774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Allow multiple empty
EffectModule.forRoot()
.Within Google we have a number of cases with empty
EffectModule.forRoot()
have to be added for tests to be able to find this module - ngc has a hard time generating a summary for EffectsModule.forRoot otherwise.Up until now, the solution was to just remove the guard altogether when merging NgRx locally, but that's not a sustainable approach and requires "un-doing" it with every merge.
Does this PR introduce a breaking change?
Other information