Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-devtools): pass entire error object to the error handler #2853

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

r0ss0neri
Copy link
Contributor

@r0ss0neri r0ss0neri commented Jan 3, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behaviour?

Closes #2824

Does this PR introduce a breaking change?

[x] Yes
[ ] No

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 3, 2021

Preview docs changes for 8ffb6d2 at https://previews.ngrx.io/pr2853-8ffb6d2e/

Copy link
Member

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but I'd consider it a breaking change that we need to add to the migration guide

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can find the migration guide here. Are you going to add a note here @r0ss0neri ?

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this and add a note to the migrations.

@timdeschryver timdeschryver merged commit ce28b44 into ngrx:master Jan 11, 2021
@r0ss0neri
Copy link
Contributor Author

I'll merge this and add a note to the migrations.

@timdeschryver thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Error object to be passed to the error handler instead of error stack string
4 participants