Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): add object-style StoreModule.forFeature overload w/fixes #2885

Merged
merged 2 commits into from
Jan 17, 2021

Conversation

brandonroberts
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Builds on top of the original PR by @lacolaco to add interop with Redux Toolkit style of { name, reducer }, with additional fixes for AOT compliance. Also added usage to the example app. In order to preserve original commit author, the PR will be rebased and merged if it lands.

Closes #2809

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@brandonroberts brandonroberts merged commit a9468e1 into master Jan 17, 2021
@timdeschryver timdeschryver deleted the store-feature-object branch January 18, 2021 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add overload support for StoreModule.forFeature({ name, reducer })
3 participants