Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store): register eslint-plugin-ngrx with ng add #3014

Merged
merged 1 commit into from
May 10, 2021

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@timdeschryver
Copy link
Member Author

I forgot to add a description...

This PR will install the ESLint plugin as a dev dependency if there's a .eslintrc.json file in the root of the project. If the config is there, it will register the NgRx plugin, and configures it to use the recommended config.

@brandonroberts brandonroberts merged commit 5259890 into master May 10, 2021
@brandonroberts brandonroberts deleted the eslint-plugin-ngrx branch May 10, 2021 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants