Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): remove strict typing for optimistic false #3020

Merged

Conversation

yharaskrik
Copy link
Contributor

Additional overload for .add() on NgRx Data Service causes issue when passing in boolean to isOptimistic. Remove overload as it should not be needed. Resolves #2928

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Cannot add a pass through function with a parameter of EntityActionOptions as boolean is not assignable to false

Closes #2928

What is the new behavior?

Looser typing allows passing EntityActionOptions through

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Additional overload for `.add()` on NgRx Data Service causes issue when passing in `boolean` to `isOptimistic`. Remove overload as it should not be needed. Resolves ngrx#2928
@ngrxbot
Copy link
Collaborator

ngrxbot commented May 15, 2021

Preview docs changes for b6a1760 at https://previews.ngrx.io/pr3020-b6a17609/

@brandonroberts brandonroberts merged commit 3b565b4 into ngrx:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants