Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): avoid early destruction of view in ngrxLet which interfered with animations (#2890) #3045

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Conversation

samuelfernandez
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2890

What is the new behavior?

Let ViewContainerRef destroy the view

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cc @BioPhoton @kamshak @4javier

@ngrxbot
Copy link
Collaborator

ngrxbot commented Jun 17, 2021

Preview docs changes for 048414e at https://previews.ngrx.io/pr3045-048414ef/

@brandonroberts brandonroberts merged commit 7515e36 into ngrx:master Jun 17, 2021
@brandonroberts
Copy link
Member

Thanks @samuelfernandez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NgrxLet: Structural directive clears view early, leading to issues with router transitions
3 participants