feat(component): add suspense template input to LetDirective #3377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Comment on lines
+173
to
+177
| static ngTemplateContextGuard<U>( | ||
| dir: LetDirective<U>, | ||
| ctx: unknown | null | undefined | ||
| ): ctx is LetViewContext<U> { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
moved because of the @typescript-eslint/member-ordering rule
Comment on lines
-33
to
-54
| * The `*ngrxLet` directive serves a convenient way of binding observables to a view context (a dom element scope). | ||
| * It also helps with several internal processing under the hood. | ||
| * | ||
| * The current way of binding an observable to the view looks like that: | ||
| * ```html | ||
| * <ng-container *ngIf="observableNumber$ | async as n"> | ||
| * <app-number [number]="n"> | ||
| * </app-number> | ||
| * <app-number-special [number]="n"> | ||
| * </app-number-special> | ||
| * </ng-container> | ||
| * ``` | ||
| * | ||
| * The problem is `*ngIf` is also interfering with rendering and in case of a `0` the component would be hidden | ||
| * | ||
| * Included Features: | ||
| * - binding is always present. (`*ngIf="truthy$ | async"`) | ||
| * - it takes away the multiple usages of the `async` or `ngrxPush` pipe | ||
| * - a unified/structured way of handling null and undefined | ||
| * - triggers change-detection differently if `zone.js` is present or not (`ChangeDetectorRef.detectChanges` or `ChangeDetectorRef.markForCheck`) | ||
| * - triggers change-detection differently if ViewEngine or Ivy is present (`ChangeDetectorRef.detectChanges` or `ɵdetectChanges`) | ||
| * - distinct same values in a row (distinctUntilChanged operator) |
There was a problem hiding this comment.
Removed duplicated content that is also in the let.md file. I have left a short description and examples here.
3 tasks
3 tasks
markostanimirovic
force-pushed
the
feat/component/suspense-template
branch
from
fd57c30 to
4a47bf5
Compare
timdeschryver
approved these changes
May 16, 2022
brandonroberts
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3340
What is the new behavior?
Added ability to pass the suspense template to
LetDirective:A suspense template will be displayed when passed observable is in a suspense state. If the suspense template is not passed, the behavior will remain the same:
undefined. However, there is new view context property$suspensethat can be used in this case:Does this PR introduce a breaking change?