fix: add support for TypeScript 4.8 #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.Built without sensitive environment variables
|
| @@ -2,7 +2,9 @@ import { EffectMetadata, EffectsMetadata } from './models'; | |||
| import { getCreateEffectMetadata } from './effect_creator'; | |||
| import { getEffectDecoratorMetadata } from './effect_decorator'; | |||
|
|
|||
| export function getEffectsMetadata<T>(instance: T): EffectsMetadata<T> { | |||
| export function getEffectsMetadata<T extends Object>( | |||
There was a problem hiding this comment.
this may introduce a breaking change if the getEffectsMetadata function (that is part of the public API) is used with an argument of the wrong type
| @@ -34,6 +34,6 @@ export interface EffectMetadata<T extends Object> | |||
| propertyName: EffectPropertyKey<T>; | |||
| } | |||
|
|
|||
| export type EffectsMetadata<T> = { | |||
| [key in EffectPropertyKey<T>]?: EffectConfig; | |||
| export type EffectsMetadata<T extends Object> = { | |||
| @@ -13,7 +13,7 @@ export function createRouterSelector< | |||
| return createFeatureSelector(DEFAULT_ROUTER_FEATURENAME); | |||
| } | |||
|
|
|||
| export function getSelectors<V>( | |||
| export function getSelectors<V extends Record<string, any>>( | |||
brandonroberts
approved these changes
Aug 29, 2022
timdeschryver
approved these changes
Aug 29, 2022
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #3547
What is the new behavior?
NgRx packages work with TypeScript 4.8
Does this PR introduce a breaking change?