Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router-store): set undefined for unserializable route title #3593

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3495

What is the new behavior?

MinimalRouterStateSerializer sets undefined for unserializable route title.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This is a temporary fix to avoid runtime errors when the @ngrx/router-store package is used with a custom title resolver in Angular 14. I'll create another PR that completely resolves this issue when we move to Angular 15 (that includes this fix angular/angular#47459).

@netlify
Copy link

netlify bot commented Sep 29, 2022

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e6186f7
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/6335baa8d499b100098dcca3
😎 Deploy Preview https://deploy-preview-3593--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@timdeschryver timdeschryver merged commit 8eb4001 into ngrx:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants