Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the @ngrx/component declarables standalone #3804

Closed
1 of 2 tasks
markostanimirovic opened this issue Mar 17, 2023 · 9 comments
Closed
1 of 2 tasks

Make the @ngrx/component declarables standalone #3804

markostanimirovic opened this issue Mar 17, 2023 · 9 comments
Assignees
Labels
16.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Component

Comments

@markostanimirovic
Copy link
Member

Which @ngrx/* package(s) are relevant/related to the feature request?

component

Information

Make the LetDirective and PushPipe standalone and deprecate LetModule and PushModule.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@adyngom
Copy link

adyngom commented Mar 20, 2023

@markostanimirovic how far along are you with this one and would it be a good candidate for a first issue to tackle? Cheers

@markostanimirovic
Copy link
Member Author

@adyngom

I haven't started working on it yet. Do you want to take it?

@adyngom
Copy link

adyngom commented Mar 20, 2023

@markostanimirovic yes definitely want to take a stab at it.

@stefanoslig
Copy link
Contributor

Hi @adyngom! I did some initial work on this issue. If you still want to work on it, feel free to check my PR. You can create yours and I can close mine. If not, I could finalize what I started 🙂

@adyngom
Copy link

adyngom commented Apr 5, 2023

Thank you @stefanoslig I'll take a look. I planned on picking this back up this week.

@markostanimirovic
Copy link
Member Author

We plan to release this feature in v16. @adyngom let me know if you don't have time to work on this issue, and I'll take it.

@stefanoslig
Copy link
Contributor

stefanoslig commented Apr 28, 2023

I did some initial work here: #3826

I closed this PR so @adyngom can work on this. If he doesn't have time I can also reopen the PR

@adyngom
Copy link

adyngom commented Apr 30, 2023

Hello @markostanimirovic @stefanoslig I'm honestly having trouble finding time and would not like to cause any delays. I'll try to contribute in other ways in the near future. So please move it forward and sorry about the hold up :(

@markostanimirovic
Copy link
Member Author

No worries Ady, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.x Accepting PRs community watch Someone from the community is working this issue/PR Project: Component
Projects
None yet
Development

No branches or pull requests

3 participants