feat(store): remove forbidden chars and empty str checks from createActionGroup #3857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
There will be a compilation error if we try to define actions whose names contain only empty spaces or forbidden characters:
What is the new behavior?
There is no compilation error in the example above. The
myActionGroup
object will contain the following action creators:The main reason for removing these checks is that we can never forbid all the characters we want. For example, it's possible with the current implementation to use letters from Greek Alphabet or Serbian Cyrillic when defining event names.
This change also simplifies implementation and reduces CI time for type tests.
Does this PR introduce a breaking change?