Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signals): initial setup #4002

Merged

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #3992

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Aug 11, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 9e85a20
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/64d7eb3da5af660008459f1e

@markostanimirovic markostanimirovic force-pushed the feat/signals/initial-setup branch from 5ac83e6 to a84b0ae Compare August 11, 2023 23:03
@markostanimirovic markostanimirovic changed the title feat(signals): add initial library setup feat(signals): initial setup Aug 12, 2023
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markostanimirovic
Copy link
Member Author

Good point @timdeschryver! I excluded the signals package from releasing flow since it will be released separately in the beginning.

@markostanimirovic markostanimirovic merged commit b0d63fd into ngrx:main Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/signals: Add initial library setup
3 participants