Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ngrx/signals: Add option to hide $update #4034

Closed
1 of 2 tasks
rainerhahnekamp opened this issue Sep 4, 2023 · 1 comment
Closed
1 of 2 tasks

@ngrx/signals: Add option to hide $update #4034

rainerhahnekamp opened this issue Sep 4, 2023 · 1 comment

Comments

@rainerhahnekamp
Copy link
Contributor

Which @ngrx/* package(s) are relevant/related to the feature request?

store

Information

There should be an option to hide the $update method from the outside. Otherwise components and services would have direct access to state. Logic would be spread over the code base and not kept in a central place.

I would like to add a PR but I think @markostanimirovic has already a working solution.

Describe any alternatives/workarounds you're currently using

No response

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@markostanimirovic
Copy link
Member

Closing this issue because the $update method will be removed in this PR: #4037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants