-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signals): improve state type and add type tests #4064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.
|
markostanimirovic
changed the title
fix(signals): fix state type and add type tests
fix(signals): improve state type and add type tests
Oct 14, 2023
brandonroberts
approved these changes
Oct 17, 2023
|
||
export type HasFunctionKeys<T> = T extends Record<string, unknown> | ||
? { | ||
[K in keyof T]: K extends keyof Function ? true : HasFunctionKeys<T[K]>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 this is smart
markostanimirovic
force-pushed
the
test/signals/type-tests
branch
from
October 17, 2023 21:50
f8fd07c
to
a0ee53b
Compare
timdeschryver
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #4065
DeepSignal
result is not prettified:The state can contain function properties (
name
,bind
,call
,apply
, etc.) which will throw a runtime error because signal function properties cannot be overridden.Deep signals for unknown dictionaries are accidentally created:
What is the new behavior?
DeepSignal
result is prettified:Does this PR introduce a breaking change?