-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade Angular dependencies to v17 pre-release versions #4068
Conversation
BREAKING CHANGES: The minimum required version of Angular has been updated BEFORE: The minimum required version of Angular is 16.x AFTER: The minimum required version of Angular is 17.x
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Just to be sure, the following commit was intended to make this PR right?
f33c782
Yes, Angular v17 uses the new application builder by default now, which uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I temporarily disabled some tests that depend on mockingngCore.isDevMode
using a barrel import due to some changes upstream that no longer allow you to mock that function this way. Will follow-up with fixes to re-enable those tests.