Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade Angular dependencies to v17 pre-release versions #4068

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

brandonroberts
Copy link
Member

@brandonroberts brandonroberts commented Oct 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
BREAKING CHANGES:

The minimum required version of Angular has been updated

BEFORE:

The minimum required version of Angular is 16.x

AFTER:

The minimum required version of Angular is 17.x

Other information

I temporarily disabled some tests that depend on mocking ngCore.isDevMode using a barrel import due to some changes upstream that no longer allow you to mock that function this way. Will follow-up with fixes to re-enable those tests.

BREAKING CHANGES:

The minimum required version of Angular has been updated

BEFORE:

The minimum required version of Angular is 16.x

AFTER:

The minimum required version of Angular is 17.x
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/653007e64cd9581794f3790e
😎 Deploy Preview https://deploy-preview-4068--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Just to be sure, the following commit was intended to make this PR right?
f33c782

@brandonroberts
Copy link
Member Author

LGTM 👍 Just to be sure, the following commit was intended to make this PR right? f33c782

Yes, Angular v17 uses the new application builder by default now, which uses browser instead of main in the project configuration. So in order to support ng-add and fix our tests, it had to be added.

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@brandonroberts brandonroberts merged commit 3d25047 into main Oct 18, 2023
4 checks passed
@brandonroberts brandonroberts deleted the feat-angular-v17-next branch October 18, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants