-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(store-devtools): change connectOutsideZone to be 'true' by default #4103
feat(store-devtools): change connectOutsideZone to be 'true' by default #4103
Conversation
✅ Deploy Preview for ngrx-io ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an API perspective I don't like having booleans default to true
.
Since we're going to provide a migration, could we also rename this property?
Maybe connectInsideZone
, with the default value of false
.
The migration will add connectInsideZone: true
to the config.
@@ -41,6 +48,7 @@ export class StoreDevtools implements Observer<any>, OnDestroy { | |||
public dispatcher: ActionsSubject; | |||
public liftedState: Observable<LiftedState>; | |||
public state: StateObservable; | |||
zone = inject(NgZone); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this added?
cc @brandonroberts , @markostanimirovic what do you think of a rename? |
I think your points are reasonable, and the upgrade migration would cover existing projects. |
@va-stefanek sorry, but can you rename the property to |
Agree 👍 IIRC, I initially proposed the |
|
7d6f630
to
103ac7e
Compare
557489d
to
e6eed2a
Compare
e6eed2a
to
6de0a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @va-stefanek
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Closes #4093
Does this PR introduce a breaking change?